Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

Issue 2450213002: Utilize EditCommand::setEndingSelection() taking SelectionInDOMTree (Closed)
Patch Set: 2016-10-28T14:44:14 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
index 8c25c586ae62bb19f0c76dbb3db1fbc22da98c65..70053020f158deb01a3fbf748da9a939eb708654 100644
--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
@@ -1107,7 +1107,7 @@ void DeleteSelectionCommand::doApply(EditingState* editingState) {
builder.setIsDirectional(endingSelection().isDirectional());
if (m_endingPosition.isNotNull())
builder.collapse(m_endingPosition);
- setEndingSelection(createVisibleSelection(builder.build()));
+ setEndingSelection(builder.build());
clearTransientState();
rebalanceWhitespace();
return;
@@ -1168,7 +1168,7 @@ void DeleteSelectionCommand::doApply(EditingState* editingState) {
builder.setIsDirectional(endingSelection().isDirectional());
if (m_endingPosition.isNotNull())
builder.collapse(m_endingPosition);
- setEndingSelection(createVisibleSelection(builder.build()));
+ setEndingSelection(builder.build());
if (relocatableReferencePosition.position().isNull()) {
clearTransientState();

Powered by Google App Engine
This is Rietveld 408576698