[ic] Load IC data handlers now support prototype chain checks with global and dictionary objects.

[ic] Load IC data handlers now support prototype chain checks with global and dictionary objects.

BUG=v8:5561
Committed: https://crrev.com/6ea4061b8d0e1ace1ca6ef510ea2aaf067e3d8ef
Cr-Commit-Position: refs/heads/master@{#40626}

[Igor Sheludko, 2016-10-26 19:51:28]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2016-10-26 19:51:35]

Patchset #2 (id:40001) has been deleted

[Igor Sheludko, 2016-10-26 19:51:43]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-10-26 20:08:44]

Description was changed from

==========
[ic] Implementing support for load IC data handlers that support dictionary
objects in the prototype chain.

BUG=
==========

to

==========
[ic] Load IC data handlers can now represent prototype chain checks with global
and dictionary objects.

BUG=v8:5561
==========

[Igor Sheludko, 2016-10-26 20:08:52]

Patchset #1 (id:60001) has been deleted

[Igor Sheludko, 2016-10-26 20:09:34]

Description was changed from

==========
[ic] Load IC data handlers can now represent prototype chain checks with global
and dictionary objects.

BUG=v8:5561
==========

to

==========
[ic] Load IC data handlers now support prototype chain checks with global and
dictionary objects.

BUG=v8:5561
==========

[Igor Sheludko, 2016-10-26 20:50:27]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 20:50:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 20:55:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 20:55:06]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/16824)

[Igor Sheludko, 2016-10-26 21:29:51]

Patchset #1 (id:80001) has been deleted

[Igor Sheludko, 2016-10-26 21:30:18]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 21:30:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-10-26 21:43:20]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2016-10-26 21:43:21]

PTAL

[commit-bot: I haz the power, 2016-10-26 21:59:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 21:59:29]

Dry run: This issue passed the CQ dry run.

[Jakob Kummerow, 2016-10-27 11:30:54]

LGTM with nits.

https://codereview.chromium.org/2449463002/diff/100001/src/code-stub-assemble...
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2449463002/diff/100001/src/code-stub-assemble...
src/code-stub-assembler.cc:5563: Bind(&if_negative_lookup_on_receiver);
nit: I'd put this above the "Bind(&if_check_prototypes)" block so reading order
is more in sync with execution order.

https://codereview.chromium.org/2449463002/diff/100001/src/code-stub-assemble...
src/code-stub-assembler.cc:5630: Branch(WordEqual(value,
LoadRoot(Heap::kTheHoleValueRootIndex)), &done,
Is there a reason you prefer this Branch() over "GotoIf(WordNotEqual(...),
miss)"?
(Either is fine with me.)

https://codereview.chromium.org/2449463002/diff/100001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/2449463002/diff/100001/src/ic/ic.cc#newcode902
src/ic/ic.cc:902: // We don't have to perform access checks for global proxy
objects appeared
nit: s/appeared/appearing/

https://codereview.chromium.org/2449463002/diff/100001/src/ic/ic.cc#newcode904
src/ic/ic.cc:904: // already guarantees that we receiver belongs to the same
native context.
nit: s/we/the/

https://codereview.chromium.org/2449463002/diff/100001/test/mjsunit/prototype...
File test/mjsunit/prototype-non-existing.js (right):

https://codereview.chromium.org/2449463002/diff/100001/test/mjsunit/prototype...
test/mjsunit/prototype-non-existing.js:58: %DebugPrint(global);
nit: leftover?

[Igor Sheludko, 2016-10-27 14:55:22]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[Igor Sheludko, 2016-10-27 14:55:31]

https://codereview.chromium.org/2449463002/diff/100001/src/code-stub-assemble...
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2449463002/diff/100001/src/code-stub-assemble...
src/code-stub-assembler.cc:5563: Bind(&if_negative_lookup_on_receiver);
On 2016/10/27 11:30:54, Jakob Kummerow wrote:
> nit: I'd put this above the "Bind(&if_check_prototypes)" block so reading
order
> is more in sync with execution order.

Done.

https://codereview.chromium.org/2449463002/diff/100001/src/code-stub-assemble...
src/code-stub-assembler.cc:5630: Branch(WordEqual(value,
LoadRoot(Heap::kTheHoleValueRootIndex)), &done,
On 2016/10/27 11:30:53, Jakob Kummerow wrote:
> Is there a reason you prefer this Branch() over "GotoIf(WordNotEqual(...),
> miss)"?
> (Either is fine with me.)

Because it has to be followed by Goto(&done) anyway. Updated.

https://codereview.chromium.org/2449463002/diff/100001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/2449463002/diff/100001/src/ic/ic.cc#newcode902
src/ic/ic.cc:902: // We don't have to perform access checks for global proxy
objects appeared
On 2016/10/27 11:30:54, Jakob Kummerow wrote:
> nit: s/appeared/appearing/

Given I'm going to remove the access checks in the next CL, I'll just remove
this comment from here.

https://codereview.chromium.org/2449463002/diff/100001/src/ic/ic.cc#newcode904
src/ic/ic.cc:904: // already guarantees that we receiver belongs to the same
native context.
On 2016/10/27 11:30:54, Jakob Kummerow wrote:
> nit: s/we/the/

Acknowledged.

https://codereview.chromium.org/2449463002/diff/100001/test/mjsunit/prototype...
File test/mjsunit/prototype-non-existing.js (right):

https://codereview.chromium.org/2449463002/diff/100001/test/mjsunit/prototype...
test/mjsunit/prototype-non-existing.js:58: %DebugPrint(global);
On 2016/10/27 11:30:54, Jakob Kummerow wrote:
> nit: leftover?

Done.

[commit-bot: I haz the power, 2016-10-27 14:55:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jakob Kummerow, 2016-10-27 15:19:54]

LGTM!

[commit-bot: I haz the power, 2016-10-27 15:21:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 15:21:50]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-10-27 15:30:22]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-10-27 15:30:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 15:32:40]

Description was changed from

==========
[ic] Load IC data handlers now support prototype chain checks with global and
dictionary objects.

BUG=v8:5561
==========

to

==========
[ic] Load IC data handlers now support prototype chain checks with global and
dictionary objects.

BUG=v8:5561
==========

[commit-bot: I haz the power, 2016-10-27 15:32:42]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-11-17 22:15:46]

Description was changed from

==========
[ic] Load IC data handlers now support prototype chain checks with global and
dictionary objects.

BUG=v8:5561
==========

to

==========
[ic] Load IC data handlers now support prototype chain checks with global and
dictionary objects.

BUG=v8:5561

Committed: https://crrev.com/6ea4061b8d0e1ace1ca6ef510ea2aaf067e3d8ef
Cr-Commit-Position: refs/heads/master@{#40626}
==========

[commit-bot: I haz the power, 2016-11-17 22:15:47]

Patchset 2 (id:??) landed as
https://crrev.com/6ea4061b8d0e1ace1ca6ef510ea2aaf067e3d8ef
Cr-Commit-Position: refs/heads/master@{#40626}