Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ic/arm/handler-compiler-arm.cc

Issue 2449463002: [ic] Load IC data handlers now support prototype chain checks with global and dictionary objects. (Closed)
Patch Set: Addressing comments and fixing the handlers in new space issue Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 // checks are allowed in stubs. 471 // checks are allowed in stubs.
472 DCHECK(current_map->IsJSGlobalProxyMap() || 472 DCHECK(current_map->IsJSGlobalProxyMap() ||
473 !current_map->is_access_check_needed()); 473 !current_map->is_access_check_needed());
474 474
475 prototype = handle(JSObject::cast(current_map->prototype())); 475 prototype = handle(JSObject::cast(current_map->prototype()));
476 if (current_map->IsJSGlobalObjectMap()) { 476 if (current_map->IsJSGlobalObjectMap()) {
477 GenerateCheckPropertyCell(masm(), Handle<JSGlobalObject>::cast(current), 477 GenerateCheckPropertyCell(masm(), Handle<JSGlobalObject>::cast(current),
478 name, scratch2, miss); 478 name, scratch2, miss);
479 } else if (current_map->is_dictionary_map()) { 479 } else if (current_map->is_dictionary_map()) {
480 DCHECK(!current_map->IsJSGlobalProxyMap()); // Proxy maps are fast. 480 DCHECK(!current_map->IsJSGlobalProxyMap()); // Proxy maps are fast.
481 if (!name->IsUniqueName()) { 481 DCHECK(name->IsUniqueName());
482 DCHECK(name->IsString());
483 name = factory()->InternalizeString(Handle<String>::cast(name));
484 }
485 DCHECK(current.is_null() || 482 DCHECK(current.is_null() ||
486 current->property_dictionary()->FindEntry(name) == 483 current->property_dictionary()->FindEntry(name) ==
487 NameDictionary::kNotFound); 484 NameDictionary::kNotFound);
488 485
489 if (depth > 1) { 486 if (depth > 1) {
490 Handle<WeakCell> weak_cell = 487 Handle<WeakCell> weak_cell =
491 Map::GetOrCreatePrototypeWeakCell(current, isolate()); 488 Map::GetOrCreatePrototypeWeakCell(current, isolate());
492 __ LoadWeakValue(reg, weak_cell, miss); 489 __ LoadWeakValue(reg, weak_cell, miss);
493 } 490 }
494 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, scratch1, 491 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, scratch1,
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 // Return the generated code. 689 // Return the generated code.
693 return GetCode(kind(), name); 690 return GetCode(kind(), name);
694 } 691 }
695 692
696 693
697 #undef __ 694 #undef __
698 } // namespace internal 695 } // namespace internal
699 } // namespace v8 696 } // namespace v8
700 697
701 #endif // V8_TARGET_ARCH_ARM 698 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698