Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Side by Side Diff: src/ic/s390/handler-compiler-s390.cc

Issue 2449463002: [ic] Load IC data handlers now support prototype chain checks with global and dictionary objects. (Closed)
Patch Set: Addressing comments and fixing the handlers in new space issue Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ppc/handler-compiler-ppc.cc ('k') | src/ic/stub-cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 // checks are allowed in stubs. 445 // checks are allowed in stubs.
446 DCHECK(current_map->IsJSGlobalProxyMap() || 446 DCHECK(current_map->IsJSGlobalProxyMap() ||
447 !current_map->is_access_check_needed()); 447 !current_map->is_access_check_needed());
448 448
449 prototype = handle(JSObject::cast(current_map->prototype())); 449 prototype = handle(JSObject::cast(current_map->prototype()));
450 if (current_map->IsJSGlobalObjectMap()) { 450 if (current_map->IsJSGlobalObjectMap()) {
451 GenerateCheckPropertyCell(masm(), Handle<JSGlobalObject>::cast(current), 451 GenerateCheckPropertyCell(masm(), Handle<JSGlobalObject>::cast(current),
452 name, scratch2, miss); 452 name, scratch2, miss);
453 } else if (current_map->is_dictionary_map()) { 453 } else if (current_map->is_dictionary_map()) {
454 DCHECK(!current_map->IsJSGlobalProxyMap()); // Proxy maps are fast. 454 DCHECK(!current_map->IsJSGlobalProxyMap()); // Proxy maps are fast.
455 if (!name->IsUniqueName()) { 455 DCHECK(name->IsUniqueName());
456 DCHECK(name->IsString());
457 name = factory()->InternalizeString(Handle<String>::cast(name));
458 }
459 DCHECK(current.is_null() || 456 DCHECK(current.is_null() ||
460 current->property_dictionary()->FindEntry(name) == 457 current->property_dictionary()->FindEntry(name) ==
461 NameDictionary::kNotFound); 458 NameDictionary::kNotFound);
462 459
463 if (depth > 1) { 460 if (depth > 1) {
464 Handle<WeakCell> weak_cell = 461 Handle<WeakCell> weak_cell =
465 Map::GetOrCreatePrototypeWeakCell(current, isolate()); 462 Map::GetOrCreatePrototypeWeakCell(current, isolate());
466 __ LoadWeakValue(reg, weak_cell, miss); 463 __ LoadWeakValue(reg, weak_cell, miss);
467 } 464 }
468 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, scratch1, 465 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, scratch1,
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
656 653
657 // Return the generated code. 654 // Return the generated code.
658 return GetCode(kind(), name); 655 return GetCode(kind(), name);
659 } 656 }
660 657
661 #undef __ 658 #undef __
662 } // namespace internal 659 } // namespace internal
663 } // namespace v8 660 } // namespace v8
664 661
665 #endif // V8_TARGET_ARCH_ARM 662 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/ppc/handler-compiler-ppc.cc ('k') | src/ic/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698