Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ic/arm64/handler-compiler-arm64.cc

Issue 2449463002: [ic] Load IC data handlers now support prototype chain checks with global and dictionary objects. (Closed)
Patch Set: Addressing comments and fixing the handlers in new space issue Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm/handler-compiler-arm.cc ('k') | src/ic/handler-configuration.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 490 matching lines...) Expand 10 before | Expand all | Expand 10 after
501 // checks are allowed in stubs. 501 // checks are allowed in stubs.
502 DCHECK(current_map->IsJSGlobalProxyMap() || 502 DCHECK(current_map->IsJSGlobalProxyMap() ||
503 !current_map->is_access_check_needed()); 503 !current_map->is_access_check_needed());
504 504
505 prototype = handle(JSObject::cast(current_map->prototype())); 505 prototype = handle(JSObject::cast(current_map->prototype()));
506 if (current_map->IsJSGlobalObjectMap()) { 506 if (current_map->IsJSGlobalObjectMap()) {
507 GenerateCheckPropertyCell(masm(), Handle<JSGlobalObject>::cast(current), 507 GenerateCheckPropertyCell(masm(), Handle<JSGlobalObject>::cast(current),
508 name, scratch2, miss); 508 name, scratch2, miss);
509 } else if (current_map->is_dictionary_map()) { 509 } else if (current_map->is_dictionary_map()) {
510 DCHECK(!current_map->IsJSGlobalProxyMap()); // Proxy maps are fast. 510 DCHECK(!current_map->IsJSGlobalProxyMap()); // Proxy maps are fast.
511 if (!name->IsUniqueName()) { 511 DCHECK(name->IsUniqueName());
512 DCHECK(name->IsString());
513 name = factory()->InternalizeString(Handle<String>::cast(name));
514 }
515 DCHECK(current.is_null() || (current->property_dictionary()->FindEntry( 512 DCHECK(current.is_null() || (current->property_dictionary()->FindEntry(
516 name) == NameDictionary::kNotFound)); 513 name) == NameDictionary::kNotFound));
517 514
518 if (depth > 1) { 515 if (depth > 1) {
519 Handle<WeakCell> weak_cell = 516 Handle<WeakCell> weak_cell =
520 Map::GetOrCreatePrototypeWeakCell(current, isolate()); 517 Map::GetOrCreatePrototypeWeakCell(current, isolate());
521 __ LoadWeakValue(reg, weak_cell, miss); 518 __ LoadWeakValue(reg, weak_cell, miss);
522 } 519 }
523 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, scratch1, 520 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, scratch1,
524 scratch2); 521 scratch2);
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
689 // Return the generated code. 686 // Return the generated code.
690 return GetCode(kind(), name); 687 return GetCode(kind(), name);
691 } 688 }
692 689
693 690
694 #undef __ 691 #undef __
695 } // namespace internal 692 } // namespace internal
696 } // namespace v8 693 } // namespace v8
697 694
698 #endif // V8_TARGET_ARCH_IA32 695 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/arm/handler-compiler-arm.cc ('k') | src/ic/handler-configuration.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698