[ic] Remove unnecessary access rights checks from the IC handlers.

[ic] Remove unnecessary access rights checks from the IC handlers.

The reasons are:
1) Type feedback vectors are not shared between different native contexts and
   therefore the IC handler created for one native context will not be reused
   in other native context.
2) Access rights revocation is not supported at all, therefore given (1) once
   we pass the access check we don't have to check access rights again.

BUG=v8:5561
Committed: https://crrev.com/8ba4af44eaa10944b99b40bc02f010eb5f432263
Cr-Commit-Position: refs/heads/master@{#40627}

[Igor Sheludko, 2016-10-27 10:11:37]

Description was changed from

==========
[ic] Remove unnecessary access rights checks from the IC handlers.

The reasons:
1) Type feedback vectors are not shared between different native contexts and
   therefore the IC handler created for one native context will not be reused
   in other native context.
2) Access rights revocation is not supported at all, therefore given (1) once
   we pass the access check we don't have to check access rights again.

BUG=v8:5561
==========

to

==========
[ic] Remove unnecessary access rights checks from the IC handlers.

The reasons are:
1) Type feedback vectors are not shared between different native contexts and
   therefore the IC handler created for one native context will not be reused
   in other native context.
2) Access rights revocation is not supported at all, therefore given (1) once
   we pass the access check we don't have to check access rights again.

BUG=v8:5561
==========

[Igor Sheludko, 2016-10-27 10:11:43]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 10:11:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-10-27 10:11:56]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2016-10-27 10:11:57]

PTAL

[commit-bot: I haz the power, 2016-10-27 10:29:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 10:29:57]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11588)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Jakob Kummerow, 2016-10-27 11:37:21]

Awesome! LGTM if you can make that test pass.

https://codereview.chromium.org/2455953002/diff/1/src/ia32/macro-assembler-ia...
File src/ia32/macro-assembler-ia32.cc (left):

https://codereview.chromium.org/2455953002/diff/1/src/ia32/macro-assembler-ia...
src/ia32/macro-assembler-ia32.cc:1311: Check(not_equal,
kWeShouldNotHaveAnEmptyLexicalContext);
The BailoutReasons kWeShouldNotHaveAnEmptyLexicalContext,
kJSGlobalObjectNativeContextShouldBeANativeContext,
kJSGlobalProxyContextShouldNotBeNull can all go too.

[Igor Sheludko, 2016-10-27 14:57:15]

https://codereview.chromium.org/2455953002/diff/1/src/ia32/macro-assembler-ia...
File src/ia32/macro-assembler-ia32.cc (left):

https://codereview.chromium.org/2455953002/diff/1/src/ia32/macro-assembler-ia...
src/ia32/macro-assembler-ia32.cc:1311: Check(not_equal,
kWeShouldNotHaveAnEmptyLexicalContext);
On 2016/10/27 11:37:21, Jakob Kummerow wrote:
> The BailoutReasons kWeShouldNotHaveAnEmptyLexicalContext,
> kJSGlobalObjectNativeContextShouldBeANativeContext,
> kJSGlobalProxyContextShouldNotBeNull can all go too.

Done.

[Igor Sheludko, 2016-10-27 14:57:43]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 14:57:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 15:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 15:26:29]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-10-27 15:51:40]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-10-27 15:51:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2455953002/#ps20001
(title: "Addressing comments and rebasing")

[commit-bot: I haz the power, 2016-10-27 15:51:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 15:53:49]

Description was changed from

==========
[ic] Remove unnecessary access rights checks from the IC handlers.

The reasons are:
1) Type feedback vectors are not shared between different native contexts and
   therefore the IC handler created for one native context will not be reused
   in other native context.
2) Access rights revocation is not supported at all, therefore given (1) once
   we pass the access check we don't have to check access rights again.

BUG=v8:5561
==========

to

==========
[ic] Remove unnecessary access rights checks from the IC handlers.

The reasons are:
1) Type feedback vectors are not shared between different native contexts and
   therefore the IC handler created for one native context will not be reused
   in other native context.
2) Access rights revocation is not supported at all, therefore given (1) once
   we pass the access check we don't have to check access rights again.

BUG=v8:5561
==========

[commit-bot: I haz the power, 2016-10-27 15:53:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:15:48]

Description was changed from

==========
[ic] Remove unnecessary access rights checks from the IC handlers.

The reasons are:
1) Type feedback vectors are not shared between different native contexts and
   therefore the IC handler created for one native context will not be reused
   in other native context.
2) Access rights revocation is not supported at all, therefore given (1) once
   we pass the access check we don't have to check access rights again.

BUG=v8:5561
==========

to

==========
[ic] Remove unnecessary access rights checks from the IC handlers.

The reasons are:
1) Type feedback vectors are not shared between different native contexts and
   therefore the IC handler created for one native context will not be reused
   in other native context.
2) Access rights revocation is not supported at all, therefore given (1) once
   we pass the access check we don't have to check access rights again.

BUG=v8:5561

Committed: https://crrev.com/8ba4af44eaa10944b99b40bc02f010eb5f432263
Cr-Commit-Position: refs/heads/master@{#40627}
==========

[commit-bot: I haz the power, 2016-11-17 22:15:50]

Patchset 2 (id:??) landed as
https://crrev.com/8ba4af44eaa10944b99b40bc02f010eb5f432263
Cr-Commit-Position: refs/heads/master@{#40627}