Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: src/ic/ppc/handler-compiler-ppc.cc

Issue 2449463002: [ic] Load IC data handlers now support prototype chain checks with global and dictionary objects. (Closed)
Patch Set: Addressing comments and fixing the handlers in new space issue Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips64/handler-compiler-mips64.cc ('k') | src/ic/s390/handler-compiler-s390.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 // checks are allowed in stubs. 465 // checks are allowed in stubs.
466 DCHECK(current_map->IsJSGlobalProxyMap() || 466 DCHECK(current_map->IsJSGlobalProxyMap() ||
467 !current_map->is_access_check_needed()); 467 !current_map->is_access_check_needed());
468 468
469 prototype = handle(JSObject::cast(current_map->prototype())); 469 prototype = handle(JSObject::cast(current_map->prototype()));
470 if (current_map->IsJSGlobalObjectMap()) { 470 if (current_map->IsJSGlobalObjectMap()) {
471 GenerateCheckPropertyCell(masm(), Handle<JSGlobalObject>::cast(current), 471 GenerateCheckPropertyCell(masm(), Handle<JSGlobalObject>::cast(current),
472 name, scratch2, miss); 472 name, scratch2, miss);
473 } else if (current_map->is_dictionary_map()) { 473 } else if (current_map->is_dictionary_map()) {
474 DCHECK(!current_map->IsJSGlobalProxyMap()); // Proxy maps are fast. 474 DCHECK(!current_map->IsJSGlobalProxyMap()); // Proxy maps are fast.
475 if (!name->IsUniqueName()) { 475 DCHECK(name->IsUniqueName());
476 DCHECK(name->IsString());
477 name = factory()->InternalizeString(Handle<String>::cast(name));
478 }
479 DCHECK(current.is_null() || 476 DCHECK(current.is_null() ||
480 current->property_dictionary()->FindEntry(name) == 477 current->property_dictionary()->FindEntry(name) ==
481 NameDictionary::kNotFound); 478 NameDictionary::kNotFound);
482 479
483 if (depth > 1) { 480 if (depth > 1) {
484 Handle<WeakCell> weak_cell = 481 Handle<WeakCell> weak_cell =
485 Map::GetOrCreatePrototypeWeakCell(current, isolate()); 482 Map::GetOrCreatePrototypeWeakCell(current, isolate());
486 __ LoadWeakValue(reg, weak_cell, miss); 483 __ LoadWeakValue(reg, weak_cell, miss);
487 } 484 }
488 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, scratch1, 485 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, scratch1,
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
686 // Return the generated code. 683 // Return the generated code.
687 return GetCode(kind(), name); 684 return GetCode(kind(), name);
688 } 685 }
689 686
690 687
691 #undef __ 688 #undef __
692 } // namespace internal 689 } // namespace internal
693 } // namespace v8 690 } // namespace v8
694 691
695 #endif // V8_TARGET_ARCH_ARM 692 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/ic/mips64/handler-compiler-mips64.cc ('k') | src/ic/s390/handler-compiler-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698