Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: src/ic/mips/handler-compiler-mips.cc

Issue 2449463002: [ic] Load IC data handlers now support prototype chain checks with global and dictionary objects. (Closed)
Patch Set: Addressing comments and fixing the handlers in new space issue Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ic-inl.h ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 // checks are allowed in stubs. 457 // checks are allowed in stubs.
458 DCHECK(current_map->IsJSGlobalProxyMap() || 458 DCHECK(current_map->IsJSGlobalProxyMap() ||
459 !current_map->is_access_check_needed()); 459 !current_map->is_access_check_needed());
460 460
461 prototype = handle(JSObject::cast(current_map->prototype())); 461 prototype = handle(JSObject::cast(current_map->prototype()));
462 if (current_map->IsJSGlobalObjectMap()) { 462 if (current_map->IsJSGlobalObjectMap()) {
463 GenerateCheckPropertyCell(masm(), Handle<JSGlobalObject>::cast(current), 463 GenerateCheckPropertyCell(masm(), Handle<JSGlobalObject>::cast(current),
464 name, scratch2, miss); 464 name, scratch2, miss);
465 } else if (current_map->is_dictionary_map()) { 465 } else if (current_map->is_dictionary_map()) {
466 DCHECK(!current_map->IsJSGlobalProxyMap()); // Proxy maps are fast. 466 DCHECK(!current_map->IsJSGlobalProxyMap()); // Proxy maps are fast.
467 if (!name->IsUniqueName()) { 467 DCHECK(name->IsUniqueName());
468 DCHECK(name->IsString());
469 name = factory()->InternalizeString(Handle<String>::cast(name));
470 }
471 DCHECK(current.is_null() || 468 DCHECK(current.is_null() ||
472 current->property_dictionary()->FindEntry(name) == 469 current->property_dictionary()->FindEntry(name) ==
473 NameDictionary::kNotFound); 470 NameDictionary::kNotFound);
474 471
475 if (depth > 1) { 472 if (depth > 1) {
476 Handle<WeakCell> weak_cell = 473 Handle<WeakCell> weak_cell =
477 Map::GetOrCreatePrototypeWeakCell(current, isolate()); 474 Map::GetOrCreatePrototypeWeakCell(current, isolate());
478 __ LoadWeakValue(reg, weak_cell, miss); 475 __ LoadWeakValue(reg, weak_cell, miss);
479 } 476 }
480 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, scratch1, 477 GenerateDictionaryNegativeLookup(masm(), miss, reg, name, scratch1,
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
677 // Return the generated code. 674 // Return the generated code.
678 return GetCode(kind(), name); 675 return GetCode(kind(), name);
679 } 676 }
680 677
681 678
682 #undef __ 679 #undef __
683 } // namespace internal 680 } // namespace internal
684 } // namespace v8 681 } // namespace v8
685 682
686 #endif // V8_TARGET_ARCH_MIPS 683 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic/ic-inl.h ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698