Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2442673002: Get rid of createVisibleSelection() taking one Position (Closed)

Created:
4 years, 2 months ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, groby+blinkspell_chromium.org, kinuko+watch, mlamouri+watch-blink_chromium.org, rwlbuis, sof, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of flat tree version of createVisibleSelection() taking one ePosition This patch gets rid of flat tree version of |createVisibleSelection()| taking one |Position| by replacing with |SelectionInDOMTree| version to reduce number of overloads for improving code health. BUG=657237 TEST=n/a; no behavior changes Committed: https://crrev.com/7fffd89947118c4719ccfb7afceae7ca66d93f5b Cr-Commit-Position: refs/heads/master@{#427280}

Patch Set 1 : 2016-10-21T16:50:37 #

Patch Set 2 : 2016-10-24T16:55:38 #

Patch Set 3 : 2016-10-24T17:42:38 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -69 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp View 3 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 2 chunks +12 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp View 3 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 4 chunks +18 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 2 1 chunk +12 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (16 generated)
yosin_UTC9
PTAL Similar to http://crrev.com/2437873008, which getting rig of createVisibleSelection() taking two VisiblePosition.
4 years, 1 month ago (2016-10-24 09:34:36 UTC) #13
tkent
lgtm
4 years, 1 month ago (2016-10-25 03:37:48 UTC) #16
yoichio
lgtm
4 years, 1 month ago (2016-10-25 03:45:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442673002/40001
4 years, 1 month ago (2016-10-25 04:14:15 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-25 05:21:22 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 05:23:24 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7fffd89947118c4719ccfb7afceae7ca66d93f5b
Cr-Commit-Position: refs/heads/master@{#427280}

Powered by Google App Engine
This is Rietveld 408576698