Get rid of createVisibleSelection() taking one Position

third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

 /*
  * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1075 matching lines @@
   saveTypingStyleState();
 
   // deleting just a BR is handled specially, at least because we do not
   // want to replace it with a placeholder BR!
   bool brResult = handleSpecialCaseBRDelete(editingState);
   if (editingState->isAborted())
     return;
   if (brResult) {
     calculateTypingStyleAfterDelete();
     document().updateStyleAndLayoutIgnorePendingStylesheets();
-    setEndingSelection(createVisibleSelection(
-        m_endingPosition, affinity, endingSelection().isDirectional()));
+    SelectionInDOMTree::Builder builder;
+    builder.setAffinity(affinity);
+    builder.setIsDirectional(endingSelection().isDirectional());
+    if (m_endingPosition.isNotNull())
+      builder.collapse(m_endingPosition);
+    setEndingSelection(createVisibleSelection(builder.build()));
     clearTransientState();
     rebalanceWhitespace();
     return;
   }
 
   document().updateStyleAndLayoutIgnorePendingStylesheets();
 
   handleGeneralDelete(editingState);
   if (editingState->isAborted())
     return;
@@ skipping 35 matching lines @@
         return;
     }
   }
 
   rebalanceWhitespaceAt(m_endingPosition);
 
   calculateTypingStyleAfterDelete();
 
   document().updateStyleAndLayoutIgnorePendingStylesheets();
 
-  setEndingSelection(createVisibleSelection(m_endingPosition, affinity,
-                                            endingSelection().isDirectional()));
+  SelectionInDOMTree::Builder builder;
+  builder.setAffinity(affinity);
+  builder.setIsDirectional(endingSelection().isDirectional());
+  if (m_endingPosition.isNotNull())
+    builder.collapse(m_endingPosition);
+  setEndingSelection(createVisibleSelection(builder.build()));
 
   if (relocatableReferencePosition.position().isNull()) {
     clearTransientState();
     return;
   }
 
   // This deletion command is part of a move operation, we need to cleanup after
   // deletion.
   m_referenceMovePosition = relocatableReferencePosition.position();
   // If the node for the destination has been removed as a result of the
@@ skipping 45 matching lines @@
   visitor->trace(m_deleteIntoBlockquoteStyle);
   visitor->trace(m_startRoot);
   visitor->trace(m_endRoot);
   visitor->trace(m_startTableRow);
   visitor->trace(m_endTableRow);
   visitor->trace(m_temporaryPlaceholder);
   CompositeEditCommand::trace(visitor);
 }
 
 }  // namespace blink