third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp - Issue 2442673002: Get rid of createVisibleSelection() taking one Position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2442673002: Get rid of createVisibleSelection() taking one Position (Closed)

Patch Set: 2016-10-24T17:42:38 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

index adfc9fb85a3e8be9bdbd4f139f17e07aaf1521d8..a54fa13ffba0ec46eba76523cf780028a2f858db 100644

--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

@@ -447,7 +447,7 @@ void WebFrameWidgetImpl::setFocus(bool enable) {

// caret back to the beginning of the text.

Position position(element, 0);

focusedFrame->selection().setSelection(

- createVisibleSelection(position, SelDefaultAffinity));

+ SelectionInDOMTree::Builder().collapse(position).build());

}