third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp - Issue 2442673002: Get rid of createVisibleSelection() taking one Position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

Issue 2442673002: Get rid of createVisibleSelection() taking one Position (Closed)

Patch Set: 2016-10-24T17:42:38 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleSelection.cpp ('k') | third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

index 510ebf148c61bfe1822878fee1f804fbcb9e94c5..b4625c54d0a663a586c76a599af6fb8444d5d93b 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

@@ -139,8 +139,10 @@ void ApplyBlockElementCommand::formatSelection(

return;

document().updateStyleAndLayoutIgnorePendingStylesheets();

setEndingSelection(createVisibleSelection(

- Position::beforeNode(placeholder), TextAffinity::Downstream,

- endingSelection().isDirectional()));

+ SelectionInDOMTree::Builder()

+ .collapse(Position::beforeNode(placeholder))

+ .setIsDirectional(endingSelection().isDirectional())

+ .build()));

return;

}