third_party/WebKit/Source/core/editing/VisibleSelection.h - Issue 2442673002: Get rid of createVisibleSelection() taking one Position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2442673002: Get rid of createVisibleSelection() taking one Position (Closed)

Patch Set: 2016-10-24T17:42:38 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleSelection.h

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h

index 0b42f611b310b9eec80783eb980edaadff04ae1f..a5873cf5a86c5648fe008f7e8624130812d710dd 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h

+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h

@@ -209,9 +209,6 @@ using VisibleSelectionInFlatTree =

// TODO(yosin): We should get rid of |createVisibleSelection()| overloads

// except for taking |SelectionInDOMTree| and |SelectionInFlatTree|.

CORE_EXPORT VisibleSelection createVisibleSelection(const SelectionInDOMTree&);

-CORE_EXPORT VisibleSelection createVisibleSelection(const Position&,

- TextAffinity,

- bool isDirectional = false);

CORE_EXPORT VisibleSelection

createVisibleSelection(const Position& base,

const Position& extent,