Get rid of createVisibleSelection() taking one Position

third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1841 matching lines @@
     start = end = lastPositionToSelect;
   } else {
     return;
   }
 
   m_startOfInsertedRange = start;
   m_endOfInsertedRange = end;
 
   document().updateStyleAndLayoutIgnorePendingStylesheets();
 
-  if (m_selectReplacement)
+  if (m_selectReplacement) {
     setEndingSelection(createVisibleSelection(
         start, end, SelDefaultAffinity, endingSelection().isDirectional()));
-  else
+    return;
+  }
+
+  if (end.isNotNull()) {
     setEndingSelection(createVisibleSelection(
-        end, SelDefaultAffinity, endingSelection().isDirectional()));
+        SelectionInDOMTree::Builder()
+            .collapse(end)
+            .setIsDirectional(endingSelection().isDirectional())
+            .build()));
+    return;
+  }
+  setEndingSelection(createVisibleSelection(SelectionInDOMTree()));
 }
 
 void ReplaceSelectionCommand::mergeTextNodesAroundPosition(
     Position& position,
     Position& positionOnlyToBeUpdated,
     EditingState* editingState) {
   bool positionIsOffsetInAnchor = position.isOffsetInAnchor();
   bool positionOnlyToBeUpdatedIsOffsetInAnchor =
       positionOnlyToBeUpdated.isOffsetInAnchor();
   Text* text = nullptr;
@@ skipping 215 matching lines @@
   visitor->trace(m_startOfInsertedContent);
   visitor->trace(m_endOfInsertedContent);
   visitor->trace(m_insertionStyle);
   visitor->trace(m_documentFragment);
   visitor->trace(m_startOfInsertedRange);
   visitor->trace(m_endOfInsertedRange);
   CompositeEditCommand::trace(visitor);
 }
 
 }  // namespace blink