Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2442673002: Get rid of createVisibleSelection() taking one Position (Closed)
Patch Set: 2016-10-24T17:42:38 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 extern template class CORE_EXTERN_TEMPLATE_EXPORT 202 extern template class CORE_EXTERN_TEMPLATE_EXPORT
203 VisibleSelectionTemplate<EditingInFlatTreeStrategy>; 203 VisibleSelectionTemplate<EditingInFlatTreeStrategy>;
204 204
205 using VisibleSelection = VisibleSelectionTemplate<EditingStrategy>; 205 using VisibleSelection = VisibleSelectionTemplate<EditingStrategy>;
206 using VisibleSelectionInFlatTree = 206 using VisibleSelectionInFlatTree =
207 VisibleSelectionTemplate<EditingInFlatTreeStrategy>; 207 VisibleSelectionTemplate<EditingInFlatTreeStrategy>;
208 208
209 // TODO(yosin): We should get rid of |createVisibleSelection()| overloads 209 // TODO(yosin): We should get rid of |createVisibleSelection()| overloads
210 // except for taking |SelectionInDOMTree| and |SelectionInFlatTree|. 210 // except for taking |SelectionInDOMTree| and |SelectionInFlatTree|.
211 CORE_EXPORT VisibleSelection createVisibleSelection(const SelectionInDOMTree&); 211 CORE_EXPORT VisibleSelection createVisibleSelection(const SelectionInDOMTree&);
212 CORE_EXPORT VisibleSelection createVisibleSelection(const Position&,
213 TextAffinity,
214 bool isDirectional = false);
215 CORE_EXPORT VisibleSelection 212 CORE_EXPORT VisibleSelection
216 createVisibleSelection(const Position& base, 213 createVisibleSelection(const Position& base,
217 const Position& extent, 214 const Position& extent,
218 TextAffinity = SelDefaultAffinity, 215 TextAffinity = SelDefaultAffinity,
219 bool isDirectional = false); 216 bool isDirectional = false);
220 CORE_EXPORT VisibleSelection createVisibleSelection(const VisiblePosition&, 217 CORE_EXPORT VisibleSelection createVisibleSelection(const VisiblePosition&,
221 const VisiblePosition&, 218 const VisiblePosition&,
222 bool isDirectional = false); 219 bool isDirectional = false);
223 220
224 CORE_EXPORT VisibleSelectionInFlatTree 221 CORE_EXPORT VisibleSelectionInFlatTree
(...skipping 14 matching lines...) Expand all
239 236
240 #ifndef NDEBUG 237 #ifndef NDEBUG
241 // Outside the WebCore namespace for ease of invocation from gdb. 238 // Outside the WebCore namespace for ease of invocation from gdb.
242 void showTree(const blink::VisibleSelection&); 239 void showTree(const blink::VisibleSelection&);
243 void showTree(const blink::VisibleSelection*); 240 void showTree(const blink::VisibleSelection*);
244 void showTree(const blink::VisibleSelectionInFlatTree&); 241 void showTree(const blink::VisibleSelectionInFlatTree&);
245 void showTree(const blink::VisibleSelectionInFlatTree*); 242 void showTree(const blink::VisibleSelectionInFlatTree*);
246 #endif 243 #endif
247 244
248 #endif // VisibleSelection_h 245 #endif // VisibleSelection_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.cpp ('k') | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698