Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers." (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert "Make CPDF_Object containers hold objects via unique pointers." This reverts commit 1d023881cd53485303c0fcc0b5878e700dc470fd. Reason for revert -- fuzzers hit issues. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d5bd8a16565bbee05bfb8a8409f3ba90c461da0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -80 lines) Patch
M core/fpdfapi/edit/fpdf_edit_create.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/page/cpdf_allstates.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_colorspace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/fpdf_page_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_array.h View 2 chunks +3 lines, -4 lines 0 comments Download
M core/fpdfapi/parser/cpdf_array.cpp View 7 chunks +25 lines, -19 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_dictionary.cpp View 4 chunks +43 lines, -21 lines 0 comments Download
M core/fpdfapi/parser/cpdf_object_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/cpdf_reference.h View 1 chunk +0 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/parser/fpdf_parser_utility.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_formcontrol.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_interform.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfppo.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Lei, TBR
4 years, 2 months ago (2016-10-17 18:04:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425783002/1
4 years, 2 months ago (2016-10-17 18:05:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/d5bd8a16565bbee05bfb8a8409f3ba90c461da0e
4 years, 2 months ago (2016-10-17 18:13:58 UTC) #5
Lei Zhang
4 years, 2 months ago (2016-10-17 22:04:28 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698