core/fpdfapi/page/fpdf_page_parser.cpp - Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/page/fpdf_page_parser.cpp

Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers." (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/page/fpdf_page_parser.cpp

diff --git a/core/fpdfapi/page/fpdf_page_parser.cpp b/core/fpdfapi/page/fpdf_page_parser.cpp

index e27872a5387e74ea9a9911360dc0c53ba03fae58..b6f0bc605cb8e4714f495641bf867adc9d8c58d5 100644

--- a/core/fpdfapi/page/fpdf_page_parser.cpp

+++ b/core/fpdfapi/page/fpdf_page_parser.cpp

@@ -97,7 +97,7 @@ void PDF_ReplaceAbbr(CPDF_Object* pObj) {

std::vector<AbbrReplacementOp> replacements;

for (const auto& it : *pDict) {

CFX_ByteString key = it.first;

- CPDF_Object* value = it.second.get();

+ CPDF_Object* value = it.second;

CFX_ByteStringC fullname =

PDF_FindFullName(PDF_InlineKeyAbbr, FX_ArraySize(PDF_InlineKeyAbbr),

key.AsStringC());

« no previous file with comments | « core/fpdfapi/page/cpdf_colorspace.cpp ('k') | core/fpdfapi/parser/cpdf_array.h » ('j') | no next file with comments »