fpdfsdk/formfiller/cba_fontmap.cpp - Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/formfiller/cba_fontmap.cpp

Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers." (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/formfiller/cba_fontmap.cpp

diff --git a/fpdfsdk/formfiller/cba_fontmap.cpp b/fpdfsdk/formfiller/cba_fontmap.cpp

index 7178b902d022fbe3773464a0df97075f8b3d8305..26feaf765d68a9877c9ad87a2581d0fd884b4f6a 100644

--- a/fpdfsdk/formfiller/cba_fontmap.cpp

+++ b/fpdfsdk/formfiller/cba_fontmap.cpp

@@ -119,7 +119,7 @@ CPDF_Font* CBA_FontMap::FindResFontSameCharset(CPDF_Dictionary* pResDict,

CPDF_Font* pFind = nullptr;

for (const auto& it : *pFonts) {

const CFX_ByteString& csKey = it.first;

- CPDF_Object* pObj = it.second.get();

+ CPDF_Object* pObj = it.second;

if (!pObj)

continue;

« no previous file with comments | « core/fpdfdoc/cpdf_interform.cpp ('k') | fpdfsdk/fpdf_flatten.cpp » ('j') | no next file with comments »