fpdfsdk/fpdfview.cpp - Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfview.cpp

Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers." (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfview.cpp

diff --git a/fpdfsdk/fpdfview.cpp b/fpdfsdk/fpdfview.cpp

index 7f2faa09473513ce67e3f4c0242e6ebb598491c1..3ab81fe1124321bd4f4e355aad20bdc1310eab5a 100644

--- a/fpdfsdk/fpdfview.cpp

+++ b/fpdfsdk/fpdfview.cpp

@@ -1104,7 +1104,7 @@ DLLEXPORT FPDF_DEST STDCALL FPDF_GetNamedDest(FPDF_DOCUMENT document,

int i = 0;

for (const auto& it : *pDest) {

bsName = it.first;

- pDestObj = it.second.get();

+ pDestObj = it.second;

if (!pDestObj)

continue;

if (i == index)

« no previous file with comments | « fpdfsdk/fpdfppo.cpp ('k') | fpdfsdk/javascript/Document.cpp » ('j') | no next file with comments »