core/fpdfapi/parser/cpdf_stream.h - Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_stream.h

Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers." (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_stream.h

diff --git a/core/fpdfapi/parser/cpdf_stream.h b/core/fpdfapi/parser/cpdf_stream.h

index b440f94354917c027fffa67505424aa52138df76..756eccfba1cfbb0d8253604b2cbdbefc184b6eb5 100644

--- a/core/fpdfapi/parser/cpdf_stream.h

+++ b/core/fpdfapi/parser/cpdf_stream.h

@@ -51,7 +51,7 @@ class CPDF_Stream : public CPDF_Object {

bool bDirect,

std::set<const CPDF_Object*>* pVisited) const override;

- UniqueDictionary m_pDict;

+ std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>> m_pDict;

bool m_bMemoryBased = true;

uint32_t m_dwSize = 0;

std::unique_ptr<uint8_t, FxFreeDeleter> m_pDataBuf;

« no previous file with comments | « core/fpdfapi/parser/cpdf_reference.h ('k') | core/fpdfapi/parser/fpdf_parser_utility.cpp » ('j') | no next file with comments »