core/fpdfapi/parser/fpdf_parser_utility.cpp - Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/fpdf_parser_utility.cpp

Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers." (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/fpdf_parser_utility.cpp

diff --git a/core/fpdfapi/parser/fpdf_parser_utility.cpp b/core/fpdfapi/parser/fpdf_parser_utility.cpp

index 6f1ce14d6e09ceef89c176d2e73fb9d1703fb5a1..7b9ead40051de98b5cde02aa1cf87bc7254c5da4 100644

--- a/core/fpdfapi/parser/fpdf_parser_utility.cpp

+++ b/core/fpdfapi/parser/fpdf_parser_utility.cpp

@@ -193,7 +193,7 @@ CFX_ByteTextBuf& operator<<(CFX_ByteTextBuf& buf, const CPDF_Object* pObj) {

buf << "<<";

for (const auto& it : *p) {

const CFX_ByteString& key = it.first;

- CPDF_Object* pValue = it.second.get();

+ CPDF_Object* pValue = it.second;

buf << "/" << PDF_NameEncode(key);

if (pValue && !pValue->IsInline()) {

buf << " " << pValue->GetObjNum() << " 0 R ";

« no previous file with comments | « core/fpdfapi/parser/cpdf_stream.h ('k') | core/fpdfdoc/cpdf_formcontrol.cpp » ('j') | no next file with comments »