fpdfsdk/javascript/Document.cpp - Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/Document.cpp

Issue 2425783002: Revert "Make CPDF_Object containers hold objects via unique pointers." (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/Document.cpp

diff --git a/fpdfsdk/javascript/Document.cpp b/fpdfsdk/javascript/Document.cpp

index 298c357a792f52ae05f1827cea02c7a35761feb4..0b08f66f338a7142a2ec76e187ab0d856a6c5fe5 100644

--- a/fpdfsdk/javascript/Document.cpp

+++ b/fpdfsdk/javascript/Document.cpp

@@ -808,7 +808,7 @@ FX_BOOL Document::info(IJS_Context* cc,

// It's to be compatible to non-standard info dictionary.

for (const auto& it : *pDictionary) {

const CFX_ByteString& bsKey = it.first;

- CPDF_Object* pValueObj = it.second.get();

+ CPDF_Object* pValueObj = it.second;

CFX_WideString wsKey = CFX_WideString::FromUTF8(bsKey.AsStringC());

if (pValueObj->IsString() || pValueObj->IsName()) {

pRuntime->PutObjectString(pObj, wsKey, pValueObj->GetUnicodeText());

« no previous file with comments | « fpdfsdk/fpdfview.cpp ('k') | xfa/fxfa/app/xfa_fontmgr.cpp » ('j') | no next file with comments »