Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 241713002: Remove some dead code from rendering/ folder (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
Reviewers:
pdr., esprehn
CC:
blink-reviews, mstensho+blink_opera.com, chromiumbugtracker_adobe.com, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, jchaffraix+rendering, rune+blink
Visibility:
Public.

Description

Remove some dead code from rendering/ folder Remove some dead code from rendering/ folder. Several methods were defined but never used. R=esprehn@chromium.org, pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -394 lines) Patch
M Source/core/rendering/HitTestResult.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 2 chunks +0 lines, -48 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 3 chunks +0 lines, -29 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.h View 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.cpp View 3 chunks +0 lines, -48 lines 0 comments Download
M Source/core/rendering/RenderFrameSet.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderFrameSet.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderIFrame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderIFrame.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 4 chunks +0 lines, -9 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 4 chunks +0 lines, -50 lines 0 comments Download
M Source/core/rendering/RenderLayerClipper.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayerClipper.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/rendering/RenderListItem.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M Source/core/rendering/RenderRubyBase.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderRubyBase.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderText.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/rendering/style/KeyframeList.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/KeyframeList.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 8 months ago (2014-04-17 22:25:31 UTC) #1
pdr.
On 2014/04/17 22:25:31, Chris Dumez wrote: LGTM if it passes the CQ!
6 years, 8 months ago (2014-04-17 22:35:35 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-17 22:37:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/241713002/1
6 years, 8 months ago (2014-04-17 22:37:27 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 23:19:55 UTC) #5
Message was sent while issue was closed. 
Change committed as 171899

Powered by Google App Engine
This is Rietveld 408576698