Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT family with DCHECK and so on in core/dom/. - ASSERT_UNUSED -> DCHECK* - ASSERT_NOT_REACHED -> NOTREACHED - ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK * core/dom/SpaceSplitString.h Remove two ASSERT_WITH_SECURITY_IMPLICATIONs. Vector[] has a RELEASE_ASSERT for the same condition. These ASSERT_WITH_SECURITY_IMPLICATIONs were redundant. BUG=596760 Committed: https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97 Cr-Commit-Position: refs/heads/master@{#423455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -68 lines) Patch
M third_party/WebKit/Source/core/dom/ClassCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBufferBase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBufferView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMStringList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMURL.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMURLUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IconURL.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/NameNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeListsNodeData.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PseudoElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PseudoElementData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/RawDataDocumentParser.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SecurityContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SpaceSplitString.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleSheetCandidate.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TagCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeAdopter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/URLSearchParams.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/URLSearchParams.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ViewportDescription.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackInvocation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRootRareDataV0.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
tkent
hayato@, would you review this please?
4 years, 2 months ago (2016-10-06 05:27:08 UTC) #14
hayato
lgtm
4 years, 2 months ago (2016-10-06 06:30:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401523002/40001
4 years, 2 months ago (2016-10-06 06:44:12 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 2 months ago (2016-10-06 06:52:22 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 06:54:38 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/241ea4031fccfda293385b4ce806f2596b3c4d97
Cr-Commit-Position: refs/heads/master@{#423455}

Powered by Google App Engine
This is Rietveld 408576698