third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp - Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp

Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp ('k') | third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp b/third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp

index d46e663080b4b16bd265e233843bad4ee901c8d3..7e9a808e5f9944fee991dbc26473e696c443da09 100644

--- a/third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp

@@ -53,12 +53,12 @@ void V0CustomElementObserver::notifyElementWasDestroyed(Element* element) {

void V0CustomElementObserver::observe(Element* element) {

ElementObserverMap::AddResult result = elementObservers().add(element, this);

- ASSERT_UNUSED(result, result.isNewEntry);

+ DCHECK(result.isNewEntry);

}

void V0CustomElementObserver::unobserve(Element* element) {

V0CustomElementObserver* observer = elementObservers().take(element);

- ASSERT_UNUSED(observer, observer == this);

+ DCHECK_EQ(observer, this);

}

} // namespace blink