third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp - Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp

Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/V0CustomElementException.cpp ('k') | third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp b/third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp

index fa661ccf85209979722fa075ee599f9e90f776f5..64aaaf8a13fdca0633a6341d401e52aa23c4df70 100644

--- a/third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp

@@ -58,8 +58,7 @@ void V0CustomElementMicrotaskDispatcher::doDispatch() {

// Finishing microtask work deletes all

// V0CustomElementCallbackQueues. Being in a callback delivery scope

// implies those queues could still be in use.

- ASSERT_WITH_SECURITY_IMPLICATION(

- !V0CustomElementProcessingStack::inCallbackDeliveryScope());

+ SECURITY_DCHECK(!V0CustomElementProcessingStack::inCallbackDeliveryScope());

m_phase = Resolving;