Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.h ('k') | third_party/WebKit/Source/core/dom/NodeListsNodeData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Node.cpp
diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp
index 27052e2ce6a0a9ed81c6389b79c2c880a542b0d6..fabe57459417e251105a08eea4bb665ac5297b64 100644
--- a/third_party/WebKit/Source/core/dom/Node.cpp
+++ b/third_party/WebKit/Source/core/dom/Node.cpp
@@ -280,7 +280,7 @@ Node::~Node() {
}
NodeRareData* Node::rareData() const {
- ASSERT_WITH_SECURITY_IMPLICATION(hasRareData());
+ SECURITY_DCHECK(hasRareData());
return static_cast<NodeRareData*>(m_data.m_rareData);
}
@@ -929,7 +929,7 @@ const ComputedStyle* Node::virtualEnsureComputedStyle(
}
int Node::maxCharacterOffset() const {
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return 0;
}
@@ -1323,7 +1323,7 @@ void Node::setTextContent(const String& text) {
// Do nothing.
return;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
unsigned short Node::compareDocumentPosition(
@@ -1377,7 +1377,7 @@ unsigned short Node::compareDocumentPosition(
kDocumentPositionPreceding;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return kDocumentPositionDisconnected;
}
@@ -2321,7 +2321,7 @@ void Node::setV0CustomElementState(V0CustomElementState newState) {
switch (newState) {
case V0NotCustomElement:
- ASSERT_NOT_REACHED(); // Everything starts in this state
+ NOTREACHED(); // Everything starts in this state
return;
case V0WaitingForUpgrade:
@@ -2418,7 +2418,7 @@ unsigned Node::lengthOfContents() const {
case Node::kDocumentTypeNode:
return 0;
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return 0;
}
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.h ('k') | third_party/WebKit/Source/core/dom/NodeListsNodeData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698