Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 2466 matching lines...) Expand 10 before | Expand all | Expand 10 after
2477 exceptionState)) 2477 exceptionState))
2478 return; 2478 return;
2479 setAttribute(parsedName, value); 2479 setAttribute(parsedName, value);
2480 } 2480 }
2481 2481
2482 void Element::removeAttributeInternal( 2482 void Element::removeAttributeInternal(
2483 size_t index, 2483 size_t index,
2484 SynchronizationOfLazyAttribute inSynchronizationOfLazyAttribute) { 2484 SynchronizationOfLazyAttribute inSynchronizationOfLazyAttribute) {
2485 MutableAttributeCollection attributes = 2485 MutableAttributeCollection attributes =
2486 ensureUniqueElementData().attributes(); 2486 ensureUniqueElementData().attributes();
2487 ASSERT_WITH_SECURITY_IMPLICATION(index < attributes.size()); 2487 SECURITY_DCHECK(index < attributes.size());
2488 2488
2489 QualifiedName name = attributes[index].name(); 2489 QualifiedName name = attributes[index].name();
2490 AtomicString valueBeingRemoved = attributes[index].value(); 2490 AtomicString valueBeingRemoved = attributes[index].value();
2491 2491
2492 if (!inSynchronizationOfLazyAttribute) { 2492 if (!inSynchronizationOfLazyAttribute) {
2493 if (!valueBeingRemoved.isNull()) 2493 if (!valueBeingRemoved.isNull())
2494 willModifyAttribute(name, valueBeingRemoved, nullAtom); 2494 willModifyAttribute(name, valueBeingRemoved, nullAtom);
2495 } 2495 }
2496 2496
2497 if (Attr* attrNode = attrIfExists(name)) 2497 if (Attr* attrNode = attrIfExists(name))
(...skipping 1581 matching lines...) Expand 10 before | Expand all | Expand 10 after
4079 } 4079 }
4080 4080
4081 DEFINE_TRACE_WRAPPERS(Element) { 4081 DEFINE_TRACE_WRAPPERS(Element) {
4082 if (hasRareData()) { 4082 if (hasRareData()) {
4083 visitor->traceWrappers(elementRareData()); 4083 visitor->traceWrappers(elementRareData());
4084 } 4084 }
4085 ContainerNode::traceWrappers(visitor); 4085 ContainerNode::traceWrappers(visitor);
4086 } 4086 }
4087 4087
4088 } // namespace blink 4088 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.h ('k') | third_party/WebKit/Source/core/dom/IconURL.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698