third_party/WebKit/Source/core/dom/DOMURLUtils.cpp - Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMURLUtils.cpp

Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DOMURLUtils.cpp

diff --git a/third_party/WebKit/Source/core/dom/DOMURLUtils.cpp b/third_party/WebKit/Source/core/dom/DOMURLUtils.cpp

index e27c6e40432142fc5626dbba1dadbca9a9cd717a..853ff19442489a864f3fd279b750d70b992c88f0 100644

--- a/third_party/WebKit/Source/core/dom/DOMURLUtils.cpp

+++ b/third_party/WebKit/Source/core/dom/DOMURLUtils.cpp

@@ -115,7 +115,7 @@ void DOMURLUtils::setSearch(const String& value) {

}

void DOMURLUtils::setSearchInternal(const String& value) {

- ASSERT(!m_isInUpdate);

+ DCHECK(!m_isInUpdate);

KURL kurl = url();

if (!kurl.isValid())

return;