third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp - Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp

Issue 2401523002: Replace ASSERT family with DCHECK and so on in core/dom/. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp ('k') | third_party/WebKit/Source/core/dom/shadow/ShadowRootRareDataV0.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp b/third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp

index c5aab1cc0a5c3aa81c4692deefedeb787cfd3a58..1c6f13aae45cfa2d2ee09a48ea7b074733fd0112 100644

--- a/third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp

@@ -48,7 +48,7 @@ void V0CustomElementUpgradeCandidateMap::add(

UpgradeCandidateMap::AddResult result =

m_upgradeCandidates.add(element, descriptor);

- ASSERT_UNUSED(result, result.isNewEntry);

+ DCHECK(result.isNewEntry);

UnresolvedDefinitionMap::iterator it =

m_unresolvedDefinitions.find(descriptor);

@@ -64,11 +64,11 @@ void V0CustomElementUpgradeCandidateMap::add(

void V0CustomElementUpgradeCandidateMap::elementWasDestroyed(Element* element) {

V0CustomElementObserver::elementWasDestroyed(element);

UpgradeCandidateMap::iterator candidate = m_upgradeCandidates.find(element);

- ASSERT_WITH_SECURITY_IMPLICATION(candidate != m_upgradeCandidates.end());

+ SECURITY_DCHECK(candidate != m_upgradeCandidates.end());

UnresolvedDefinitionMap::iterator elements =

m_unresolvedDefinitions.find(candidate->value);

- ASSERT_WITH_SECURITY_IMPLICATION(elements != m_unresolvedDefinitions.end());

+ SECURITY_DCHECK(elements != m_unresolvedDefinitions.end());

elements->value->remove(element);

m_upgradeCandidates.remove(candidate);

}