Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 239143007: <webview>: Move JavaScript Dialog API to chrome (Closed)

Created:
6 years, 8 months ago by Fady Samuel
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jar (doing other things), asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_pointer_lock_to_chrome
Visibility:
Public.

Description

<webview>: Move JavaScript Dialog API to chrome BUG=330264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264378

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -141 lines) Patch
A chrome/browser/guestview/webview/javascript_dialog_helper.h View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/guestview/webview/javascript_dialog_helper.cc View 1 1 chunk +104 lines, -0 lines 0 comments Download
M chrome/browser/guestview/webview/webview_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/guestview/webview/webview_constants.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/guestview/webview/webview_guest.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/guestview/webview/webview_guest.cc View 9 chunks +19 lines, -13 lines 0 comments Download
M chrome/browser/guestview/webview/webview_permission_types.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 4 chunks +1 line, -27 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 4 chunks +3 lines, -89 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_constants.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_constants.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/common/browser_plugin_permission_type.h View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/metrics/actions/actions.xml View 5 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Fady Samuel
+lazyboy@ overall review +jam@ content/public review +asvitkine@ for actions.xml
6 years, 8 months ago (2014-04-15 22:47:05 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 8 months ago (2014-04-16 13:26:39 UTC) #2
lazyboy
lgtm https://codereview.chromium.org/239143007/diff/1/chrome/browser/guestview/webview/javascript_dialog_helper.cc File chrome/browser/guestview/webview/javascript_dialog_helper.cc (right): https://codereview.chromium.org/239143007/diff/1/chrome/browser/guestview/webview/javascript_dialog_helper.cc#newcode41 chrome/browser/guestview/webview/javascript_dialog_helper.cc:41: content::WebContents* web_contents, indent. I see all the params ...
6 years, 8 months ago (2014-04-16 14:41:44 UTC) #3
lazyboy
lgtm lgtm https://codereview.chromium.org/239143007/diff/1/chrome/browser/guestview/webview/javascript_dialog_helper.cc File chrome/browser/guestview/webview/javascript_dialog_helper.cc (right): https://codereview.chromium.org/239143007/diff/1/chrome/browser/guestview/webview/javascript_dialog_helper.cc#newcode41 chrome/browser/guestview/webview/javascript_dialog_helper.cc:41: content::WebContents* web_contents, indent. I see all the ...
6 years, 8 months ago (2014-04-16 14:41:44 UTC) #4
jam
lgtm https://codereview.chromium.org/239143007/diff/1/content/public/browser/browser_plugin_guest_delegate.cc File content/public/browser/browser_plugin_guest_delegate.cc (right): https://codereview.chromium.org/239143007/diff/1/content/public/browser/browser_plugin_guest_delegate.cc#newcode44 content/public/browser/browser_plugin_guest_delegate.cc:44: BrowserPluginGuestDelegate::GetJavaScriptDialogManager() { nit: per style guide, no indentation ...
6 years, 8 months ago (2014-04-16 16:14:28 UTC) #5
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 8 months ago (2014-04-16 18:32:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/239143007/20001
6 years, 8 months ago (2014-04-16 18:33:28 UTC) #7
Fady Samuel
Addressed nits: CQ'ed. https://codereview.chromium.org/239143007/diff/1/chrome/browser/guestview/webview/javascript_dialog_helper.cc File chrome/browser/guestview/webview/javascript_dialog_helper.cc (right): https://codereview.chromium.org/239143007/diff/1/chrome/browser/guestview/webview/javascript_dialog_helper.cc#newcode41 chrome/browser/guestview/webview/javascript_dialog_helper.cc:41: content::WebContents* web_contents, On 2014/04/16 14:41:44, lazyboy ...
6 years, 8 months ago (2014-04-16 18:34:38 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 18:41:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 8 months ago (2014-04-16 18:41:52 UTC) #10
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 8 months ago (2014-04-16 21:29:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/239143007/20001
6 years, 8 months ago (2014-04-16 21:29:50 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 01:35:43 UTC) #13
Message was sent while issue was closed. 
Change committed as 264378

Powered by Google App Engine
This is Rietveld 408576698