content/public/common/browser_plugin_permission_type.h - Issue 239143007: <webview>: Move JavaScript Dialog API to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/browser_plugin_permission_type.h

Issue 239143007: <webview>: Move JavaScript Dialog API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_pointer_lock_to_chrome

Patch Set: Addressed nits Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/common/browser_plugin_permission_type.h

diff --git a/content/public/common/browser_plugin_permission_type.h b/content/public/common/browser_plugin_permission_type.h

index bf9106df7e5d90756e56b9e199acf736f9a3622b..d046d162cf2c5fe96f5c7cb0b19629c88b91593e 100644

--- a/content/public/common/browser_plugin_permission_type.h

+++ b/content/public/common/browser_plugin_permission_type.h

@@ -15,12 +15,6 @@ enum BrowserPluginPermissionType {

// permission type for code reuse.

BROWSER_PLUGIN_PERMISSION_TYPE_NEW_WINDOW,

- // JavaScript Dialogs: prompt, alert, confirm

- // Note: Even through dialogs do not use the permission API, the dialog API

- // is sufficiently similiar that it's convenient to consider it a permission

- // type for code reuse.

- BROWSER_PLUGIN_PERMISSION_TYPE_JAVASCRIPT_DIALOG,

BROWSER_PLUGIN_PERMISSION_TYPE_CONTENT_END,

};

« no previous file with comments | « content/public/browser/browser_plugin_guest_delegate.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »