content/common/browser_plugin/browser_plugin_constants.cc - Issue 239143007: <webview>: Move JavaScript Dialog API to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/browser_plugin/browser_plugin_constants.cc

Issue 239143007: <webview>: Move JavaScript Dialog API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_pointer_lock_to_chrome

Patch Set: Addressed nits Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/browser_plugin/browser_plugin_constants.h ('k') | content/public/browser/browser_plugin_guest_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/browser_plugin/browser_plugin_constants.cc

diff --git a/content/common/browser_plugin/browser_plugin_constants.cc b/content/common/browser_plugin/browser_plugin_constants.cc

index 6db08c770d9c6dab935657bcd41ca7a1265e8e75..4b413d301bbbe4cec34530ba81ae7e5197e21f58 100644

--- a/content/common/browser_plugin/browser_plugin_constants.cc

+++ b/content/common/browser_plugin/browser_plugin_constants.cc

@@ -44,13 +44,10 @@ const char kAttributePartition[] = "partition";

const char kAttributeSrc[] = "src";

// Parameters/properties on events.

-const char kDefaultPromptText[] = "defaultPromptText";

const char kId[] = "id";

const char kInitialHeight[] = "initialHeight";

const char kInitialWidth[] = "initialWidth";

const char kLastUnlockedBySelf[] = "lastUnlockedBySelf";

-const char kMessageText[] = "messageText";

-const char kMessageType[] = "messageType";

const char kName[] = "name";

const char kPermission[] = "permission";

const char kPermissionTypeDialog[] = "dialog";

« no previous file with comments | « content/common/browser_plugin/browser_plugin_constants.h ('k') | content/public/browser/browser_plugin_guest_delegate.h » ('j') | no next file with comments »