content/common/browser_plugin/browser_plugin_constants.h - Issue 239143007: <webview>: Move JavaScript Dialog API to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/browser_plugin/browser_plugin_constants.h

Issue 239143007: <webview>: Move JavaScript Dialog API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_pointer_lock_to_chrome

Patch Set: Addressed nits Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/common/browser_plugin/browser_plugin_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/browser_plugin/browser_plugin_constants.h

diff --git a/content/common/browser_plugin/browser_plugin_constants.h b/content/common/browser_plugin/browser_plugin_constants.h

index d0cb1046b069466698a26d30625a1220aef4a5f2..efcc8be015850390925508e4ece30897eacd967d 100644

--- a/content/common/browser_plugin/browser_plugin_constants.h

+++ b/content/common/browser_plugin/browser_plugin_constants.h

@@ -44,13 +44,10 @@ extern const char kAttributePartition[];

extern const char kAttributeSrc[];

// Parameters/properties on events.

-extern const char kDefaultPromptText[];

extern const char kId[];

extern const char kInitialHeight[];

extern const char kInitialWidth[];

extern const char kLastUnlockedBySelf[];

-extern const char kMessageText[];

-extern const char kMessageType[];

extern const char kName[];

extern const char kPermission[];

extern const char kPermissionTypeDialog[];