content/public/browser/browser_plugin_guest_delegate.h - Issue 239143007: <webview>: Move JavaScript Dialog API to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/browser_plugin_guest_delegate.h

Issue 239143007: <webview>: Move JavaScript Dialog API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_pointer_lock_to_chrome

Patch Set: Addressed nits Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/browser_plugin/browser_plugin_constants.cc ('k') | content/public/browser/browser_plugin_guest_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/browser_plugin_guest_delegate.h

diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h

index 2ea53676d007d862d3e0232fa4d5c4d6168fc39b..efb036cd2060516ed45a73a1bd5c59090dcae781 100644

--- a/content/public/browser/browser_plugin_guest_delegate.h

+++ b/content/public/browser/browser_plugin_guest_delegate.h

@@ -18,6 +18,7 @@

namespace content {

+class JavaScriptDialogManager;

struct NativeWebKeyboardEvent;

// Objects implement this interface to get notified about changes in the guest

@@ -122,6 +123,10 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate {

bool user_gesture,

bool last_unlocked_by_target,

const base::Callback<void(bool)>& callback) {}

+ // Returns a pointer to a service to manage JavaScript dialogs. May return

+ // NULL in which case dialogs aren't shown.

+ virtual JavaScriptDialogManager* GetJavaScriptDialogManager();

};

} // namespace content