chrome/browser/guestview/webview/webview_permission_types.h - Issue 239143007: <webview>: Move JavaScript Dialog API to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guestview/webview/webview_permission_types.h

Issue 239143007: <webview>: Move JavaScript Dialog API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_pointer_lock_to_chrome

Patch Set: Addressed nits Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/guestview/webview/webview_permission_types.h

diff --git a/chrome/browser/guestview/webview/webview_permission_types.h b/chrome/browser/guestview/webview/webview_permission_types.h

index 0a78a0486eea2037990a27f9690fccee7b654421..a532036f213a1cba29724c1822876e4d6fb4bb54 100644

--- a/chrome/browser/guestview/webview/webview_permission_types.h

+++ b/chrome/browser/guestview/webview/webview_permission_types.h

@@ -13,6 +13,12 @@ enum WebViewPermissionType {

WEB_VIEW_PERMISSION_TYPE_GEOLOCATION,

+ // JavaScript Dialogs: prompt, alert, confirm

+ // Note: Even through dialogs do not use the permission API, the dialog API

+ // is sufficiently similiar that it's convenient to consider it a permission

+ // type for code reuse.

+ WEB_VIEW_PERMISSION_TYPE_JAVASCRIPT_DIALOG,

WEB_VIEW_PERMISSION_TYPE_LOAD_PLUGIN,

// Media access (audio/video) permission request type.

« no previous file with comments | « chrome/browser/guestview/webview/webview_guest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »