Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Unified Diff: chrome/browser/guestview/webview/webview_guest.h

Issue 239143007: <webview>: Move JavaScript Dialog API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_pointer_lock_to_chrome
Patch Set: Addressed nits Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guestview/webview/webview_guest.h
diff --git a/chrome/browser/guestview/webview/webview_guest.h b/chrome/browser/guestview/webview/webview_guest.h
index aa21e40300a7670df87ceb600edd693b11ce10dd..53e2f5a0bbc19fb9284ab825d3dc1c058483a210 100644
--- a/chrome/browser/guestview/webview/webview_guest.h
+++ b/chrome/browser/guestview/webview/webview_guest.h
@@ -8,7 +8,9 @@
#include "base/observer_list.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/guestview/guestview.h"
+#include "chrome/browser/guestview/webview/javascript_dialog_helper.h"
#include "chrome/browser/guestview/webview/webview_find_helper.h"
+#include "content/public/browser/javascript_dialog_manager.h"
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/web_contents_observer.h"
#include "third_party/WebKit/public/web/WebFindOptions.h"
@@ -91,6 +93,8 @@ class WebViewGuest : public GuestView,
bool user_gesture,
bool last_unlocked_by_target,
const base::Callback<void(bool)>& callback) OVERRIDE;
+ virtual content::JavaScriptDialogManager*
+ GetJavaScriptDialogManager() OVERRIDE;
// NotificationObserver implementation.
virtual void Observe(int type,
@@ -303,6 +307,9 @@ class WebViewGuest : public GuestView,
// Handles find requests and replies for the webview find API.
WebviewFindHelper find_helper_;
+ // Handles the JavaScript dialog requests.
+ JavaScriptDialogHelper javascript_dialog_helper_;
+
friend void WebviewFindHelper::DispatchFindUpdateEvent(bool canceled,
bool final_update);
« no previous file with comments | « chrome/browser/guestview/webview/webview_constants.cc ('k') | chrome/browser/guestview/webview/webview_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698