reflow comments in core/svg/

reflow comments in core/svg/

BUG=563793
Committed: https://crrev.com/9968503c3e2d1b3003af061d1c47f017bfdd5cc9
Cr-Commit-Position: refs/heads/master@{#423015}

[Nico, 2016-10-04 20:17:51]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2016-10-04 20:18:06]

thakis@chromium.org changed reviewers:
+ pdr@chromium.org

[Nico, 2016-10-04 20:18:06]

I'm sorry.

[commit-bot: I haz the power, 2016-10-04 20:18:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-10-04 21:05:30]

LGTM with or without the double space changes.

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGAngle.cpp (right):

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGAngle.cpp:371: // (and not eg. 'auto').
Nit: maybe "(and not, for example, 'auto')."

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp (right):

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp:171: // of 0
Nit: lets make this a complete sentence: Add a period and "value, Need" ->
"value. We need"

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/svg/properties/SVGListPropertyTearOffHelper.h
(right):

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/properties/SVGListPropertyTearOffHelper.h:53:
// list
Nit: put "e.g.," on the previous line and split up the parenthesis. Or, if you
can squeeze it on one line just remove the quotes.

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/properties/SVGProperty.h (right):

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/properties/SVGProperty.h:91: // hierarchy. 
Not tracing it is safe, albeit an undesirable state of affairs.
Super nit: one space after periods for consistency.

I think everyone our age learned to type two periods as a holdover from
typewriters or something... I still type two by accident.

There are about 10 instances of this but I've just grouped them into this
comment. If you agree, please grep the patch for ".  "

[Nico, 2016-10-04 21:10:24]

Thanks!

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGAngle.cpp (right):

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGAngle.cpp:371: // (and not eg. 'auto').
On 2016/10/04 21:05:30, pdr. wrote:
> Nit: maybe "(and not, for example, 'auto')."

Done.

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp (right):

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp:171: // of 0
On 2016/10/04 21:05:30, pdr. wrote:
> Nit: lets make this a complete sentence: Add a period and "value, Need" ->
> "value. We need"

Done.

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/svg/properties/SVGListPropertyTearOffHelper.h
(right):

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/properties/SVGListPropertyTearOffHelper.h:53:
// list
On 2016/10/04 21:05:30, pdr. wrote:
> Nit: put "e.g.," on the previous line and split up the parenthesis. Or, if you
> can squeeze it on one line just remove the quotes.

Done.

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/properties/SVGProperty.h (right):

https://codereview.chromium.org/2390773004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/properties/SVGProperty.h:91: // hierarchy. 
Not tracing it is safe, albeit an undesirable state of affairs.
On 2016/10/04 21:05:30, pdr. wrote:
> Super nit: one space after periods for consistency.
> 
> I think everyone our age learned to type two periods as a holdover from
> typewriters or something... I still type two by accident.
> 
> There are about 10 instances of this but I've just grouped them into this
> comment. If you agree, please grep the patch for ".  "

I use vim's gq to join lines manually, and it defaults to two spaces
after periods.

Looks like we deliberately decided that we don't care about this a while
ago: https://codereview.chromium.org/609633004

[Nico, 2016-10-04 21:11:16]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-10-04 21:11:17]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2390773004/#ps20001
(title: "comments (heh!)")

[commit-bot: I haz the power, 2016-10-04 21:11:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 00:22:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 00:25:39]

Description was changed from

==========
reflow comments in core/svg/

BUG=563793
==========

to

==========
reflow comments in core/svg/

BUG=563793

Committed: https://crrev.com/9968503c3e2d1b3003af061d1c47f017bfdd5cc9
Cr-Commit-Position: refs/heads/master@{#423015}
==========

[commit-bot: I haz the power, 2016-10-05 00:25:40]

Patchset 2 (id:??) landed as
https://crrev.com/9968503c3e2d1b3003af061d1c47f017bfdd5cc9
Cr-Commit-Position: refs/heads/master@{#423015}