third_party/WebKit/Source/core/svg/SVGEnumeration.cpp - Issue 2390773004: reflow comments in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

Issue 2390773004: reflow comments in core/svg/ (Closed)

Patch Set: comments (heh!) Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp b/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

index de0f080c1953f2e94cab20fffb7a4ecb6bf75baa..3feca34d3b41d144e5d9494e88d06b5f9d065c63 100644

--- a/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp

@@ -63,7 +63,8 @@ void SVGEnumerationBase::setValue(unsigned short value) {

SVGParsingError SVGEnumerationBase::setValueAsString(const String& string) {

for (const auto& entry : m_entries) {

if (string == entry.second) {

- // 0 corresponds to _UNKNOWN enumeration values, and should not be settable.

+ // 0 corresponds to _UNKNOWN enumeration values, and should not be

+ // settable.

ASSERT(entry.first);

m_value = entry.first;

notifyChange();