third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp - Issue 2390773004: reflow comments in core/svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

Issue 2390773004: reflow comments in core/svg/ (Closed)

Patch Set: comments (heh!) Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGLengthList.cpp ('k') | third_party/WebKit/Source/core/svg/SVGLinearGradientElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp b/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

index b27da5d242e7e99f911423d8a761740450f71dfa..1072cfac439f5b23d289bd378cd37e8c59592772 100644

--- a/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp

@@ -166,7 +166,9 @@ void SVGLengthTearOff::setValueInSpecifiedUnits(

}

String SVGLengthTearOff::valueAsString() {

- // TODO(shanmuga.m@samsung.com): Not all <length> properties have 0 (with no unit) as the default (lacuna) value, Need to return default value instead of 0

+ // TODO(shanmuga.m@samsung.com): Not all <length> properties have 0 (with no

+ // unit) as the default (lacuna) value. We need to return default value

+ // instead of 0.

return hasExposedLengthUnit() ? target()->valueAsString() : String::number(0);

}