Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2384263003: Reflow comments in core/animation and subdirs (Closed)

Created:
4 years, 2 months ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 2 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in core/animation and subdirs BUG=563793 Committed: https://crrev.com/f053eba0ad183c9d098f18e55d14216f5deb1c0a Cr-Commit-Position: refs/heads/master@{#422692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -137 lines) Patch
M third_party/WebKit/Source/core/animation/Animation.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStack.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimations.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorPendingAnimations.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentAnimations.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/EffectInput.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/EffectModel.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimations.h View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimations.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ImageSlicePropertyFunctions.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InertEffect.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolableValue.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/Interpolation.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationEffect.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationType.h View 3 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationValue.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Keyframe.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp View 2 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/NonInterpolableValue.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PairwiseInterpolationValue.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/PrimitiveInterpolation.h View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGPathSegInterpolationFunctions.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SampledEffect.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/StyleInterpolation.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/TimingCalculations.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/TimingCalculationsTest.cpp View 5 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/TypedInterpolationValue.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/UnderlyingValueOwner.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/UnderlyingValueOwner.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableRepeatable.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableRepeatable.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValue.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 12 chunks +32 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
suzyh_UTC10 (ex-contributor)
4 years, 2 months ago (2016-10-03 22:05:17 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 2 months ago (2016-10-03 23:30:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384263003/1
4 years, 2 months ago (2016-10-04 02:03:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 03:43:03 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 03:47:34 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f053eba0ad183c9d098f18e55d14216f5deb1c0a
Cr-Commit-Position: refs/heads/master@{#422692}

Powered by Google App Engine
This is Rietveld 408576698