Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp

Issue 2384263003: Reflow comments in core/animation and subdirs (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp
diff --git a/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp b/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp
index 32978e745460e44bff6874faf1bbbd2c95e58a63..9bb18aabf5ea0518b0957344b766261ca71dd73f 100644
--- a/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp
+++ b/third_party/WebKit/Source/core/animation/LengthPropertyFunctions.cpp
@@ -95,13 +95,16 @@ static Length lengthFromUnsigned(unsigned short value) {
bool LengthPropertyFunctions::getInitialLength(CSSPropertyID property,
Length& result) {
switch (property) {
- // The computed value of "initial" for the following properties is 0px if the associated *-style property resolves to "none" or "hidden".
- // border-width: https://drafts.csswg.org/css-backgrounds-3/#the-border-width
- // outline-width: https://drafts.csswg.org/css-ui-3/#outline-width
- // column-rule-width: https://drafts.csswg.org/css-multicol-1/#crw
- // We ignore this value adjustment for animations and use the wrong value for hidden widths to avoid
- // having to restart our animations based on the computed *-style values.
- // This is acceptable since animations running on hidden widths are unobservable to the user, even via getComputedStyle().
+ // The computed value of "initial" for the following properties is 0px if
+ // the associated *-style property resolves to "none" or "hidden".
+ // - border-width:
+ // https://drafts.csswg.org/css-backgrounds-3/#the-border-width
+ // - outline-width: https://drafts.csswg.org/css-ui-3/#outline-width
+ // - column-rule-width: https://drafts.csswg.org/css-multicol-1/#crw
+ // We ignore this value adjustment for animations and use the wrong value
+ // for hidden widths to avoid having to restart our animations based on the
+ // computed *-style values. This is acceptable since animations running on
+ // hidden widths are unobservable to the user, even via getComputedStyle().
case CSSPropertyBorderBottomWidth:
case CSSPropertyBorderLeftWidth:
case CSSPropertyBorderRightWidth:
@@ -417,7 +420,8 @@ bool LengthPropertyFunctions::setLength(CSSPropertyID property,
style.setLineHeight(value);
return true;
- // TODO(alancutter): Support setters that take a numeric value (need to resolve percentages).
+ // TODO(alancutter): Support setters that take a numeric value (need to
+ // resolve percentages).
case CSSPropertyBorderBottomWidth:
case CSSPropertyBorderLeftWidth:
case CSSPropertyBorderRightWidth:

Powered by Google App Engine
This is Rietveld 408576698