third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.cpp - Issue 2384263003: Reflow comments in core/animation and subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.cpp

Issue 2384263003: Reflow comments in core/animation and subdirs (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/UnderlyingValueOwner.cpp ('k') | third_party/WebKit/Source/core/animation/animatable/AnimatableRepeatable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.cpp

diff --git a/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.cpp b/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.cpp

index 694502d0b131e45464bbeb95075e850fbf9e8367..d3e6634f9b58a1a204bef3a0a48eba665844868a 100644

--- a/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.cpp

+++ b/third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.cpp

@@ -42,8 +42,9 @@ static bool sidesHaveSameUnits(const AnimatableValue* sideA,

return toAnimatableLength(sideA)->hasSameUnits(toAnimatableLength(sideB));

}

-// This is only used by *-image-slice properties which cannot interpolate between numbers and percentages.

-// Numbers are internally represented by pixels on the ComputedStyle so we must manually type check both sides.

+// This is only used by *-image-slice properties which cannot interpolate

+// between numbers and percentages. Numbers are internally represented by pixels

+// on the ComputedStyle so we must manually type check both sides.

bool AnimatableLengthBoxAndBool::usesDefaultInterpolationWith(

const AnimatableValue* value) const {

const AnimatableLengthBoxAndBool* lengthBoxAndBool =