Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: third_party/WebKit/Source/core/animation/ElementAnimations.cpp

Issue 2384263003: Reflow comments in core/animation and subdirs (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/ElementAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/ElementAnimations.cpp b/third_party/WebKit/Source/core/animation/ElementAnimations.cpp
index 228a67eb040fd5e16918f642a73dc6ae7d8c0ff2..baac68c92ec8479e5b605ba41b71fbbfcdb520e4 100644
--- a/third_party/WebKit/Source/core/animation/ElementAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/ElementAnimations.cpp
@@ -111,12 +111,13 @@ void ElementAnimations::clearBaseComputedStyle() {
}
bool ElementAnimations::isAnimationStyleChange() const {
- // TODO(rune@opera.com): The FontFaceCache version number may be increased without forcing
- // a style recalc (see crbug.com/471079). ComputedStyle objects created with different cache
- // versions will not be considered equal as Font::operator== will compare versions, hence
- // ComputedStyle::operator== will return false. We avoid using baseComputedStyle (the check for
- // isFallbackValid()) in that case to avoid triggering the ComputedStyle comparison ASSERT
- // in updateBaseComputedStyle.
+ // TODO(rune@opera.com): The FontFaceCache version number may be increased
+ // without forcing a style recalc (see crbug.com/471079). ComputedStyle
+ // objects created with different cache versions will not be considered equal
+ // as Font::operator== will compare versions, hence ComputedStyle::operator==
+ // will return false. We avoid using baseComputedStyle (the check for
+ // isFallbackValid()) in that case to avoid triggering the ComputedStyle
+ // comparison ASSERT in updateBaseComputedStyle.
return m_animationStyleChange &&
(!m_baseComputedStyle ||
m_baseComputedStyle->font().isFallbackValid());

Powered by Google App Engine
This is Rietveld 408576698