third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp - Issue 2384263003: Reflow comments in core/animation and subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp

Issue 2384263003: Reflow comments in core/animation and subdirs (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/SVGPathSegInterpolationFunctions.cpp ('k') | third_party/WebKit/Source/core/animation/SampledEffect.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp b/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp

index 92c8ee0e6f3d55d319d0629f6a3a7cc3db787228..64caf31630c00ccf725feabf089b917cba8805ef 100644

--- a/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp

@@ -179,7 +179,8 @@ class SVGTransformListChecker : public InterpolationType::ConversionChecker {

bool isValid(const InterpolationEnvironment&,

const InterpolationValue& underlying) const final {

- // TODO(suzyh): change maybeConvertSingle so we don't have to recalculate for changes to the interpolable values

+ // TODO(suzyh): change maybeConvertSingle so we don't have to recalculate

+ // for changes to the interpolable values

if (!underlying && !m_underlying)

return true;

if (!underlying || !m_underlying)

@@ -202,7 +203,8 @@ InterpolationValue SVGTransformListInterpolationType::maybeConvertNeutral(

const InterpolationValue&,

ConversionCheckers&) const {

NOTREACHED();

- // This function is no longer called, because maybeConvertSingle has been overridden.

+ // This function is no longer called, because maybeConvertSingle has been

+ // overridden.

return nullptr;

}