Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2375873003: Make DOMWindowProperty::m_frame private (Closed)

Created:
4 years, 2 months ago by haraken
Modified:
4 years, 2 months ago
Reviewers:
dglazkov, dcheng
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, gavinp+loader_chromium.org, haraken, Nate Chapin, loading-reviews_chromium.org, michaeln, mlamouri+watch-screen-orientation_chromium.org, mlamouri+watch-blink_chromium.org, rwlbuis, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DOMWindowProperty::m_frame private BUG=610176 Committed: https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a Cr-Commit-Position: refs/heads/master@{#421741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -131 lines) Patch
M third_party/WebKit/Source/core/css/StyleMedia.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 20 chunks +32 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/frame/BarProp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindowProperty.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/History.cpp View 8 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Navigator.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Screen.cpp View 6 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/timing/Performance.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceNavigation.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceTiming.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMMimeTypeArray.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/Storage.h View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/Storage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
haraken
PTAL. This is a trivial change.
4 years, 2 months ago (2016-09-29 02:31:30 UTC) #2
dglazkov
lgtm
4 years, 2 months ago (2016-09-29 02:31:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2375873003/1
4 years, 2 months ago (2016-09-29 02:32:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 03:57:37 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 03:59:54 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a
Cr-Commit-Position: refs/heads/master@{#421741}

Powered by Google App Engine
This is Rietveld 408576698