third_party/WebKit/Source/core/frame/BarProp.cpp - Issue 2375873003: Make DOMWindowProperty::m_frame private

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/frame/BarProp.cpp

Issue 2375873003: Make DOMWindowProperty::m_frame private (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2007, 2010 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 29 matching lines...) Expand all Loading...
40 {	40 {

41 }	41 }

42	42

43 DEFINE_TRACE(BarProp)	43 DEFINE_TRACE(BarProp)

44 {	44 {

45 DOMWindowProperty::trace(visitor);	45 DOMWindowProperty::trace(visitor);

46 }	46 }

47	47

48 bool BarProp::visible() const	48 bool BarProp::visible() const

49 {	49 {

50 if (!m_frame)	50 if (!frame())

51 return false;	51 return false;

52 FrameHost* host = m_frame->host();	52 FrameHost* host = frame()->host();

53 if (!host)	53 if (!host)

54 return false;	54 return false;

55	55

56 switch (m_type) {	56 switch (m_type) {

57 case Locationbar:	57 case Locationbar:

58 case Personalbar:	58 case Personalbar:

59 case Toolbar:	59 case Toolbar:

60 return host->chromeClient().toolbarsVisible();	60 return host->chromeClient().toolbarsVisible();

61 case Menubar:	61 case Menubar:

62 return host->chromeClient().menubarVisible();	62 return host->chromeClient().menubarVisible();

63 case Scrollbars:	63 case Scrollbars:

64 return host->chromeClient().scrollbarsVisible();	64 return host->chromeClient().scrollbarsVisible();

65 case Statusbar:	65 case Statusbar:

66 return host->chromeClient().statusbarVisible();	66 return host->chromeClient().statusbarVisible();

67 }	67 }

68	68

69 ASSERT_NOT_REACHED();	69 ASSERT_NOT_REACHED();

70 return false;	70 return false;

71 }	71 }

72	72

73 } // namespace blink	73 } // namespace blink

OLD	NEW