third_party/WebKit/Source/modules/storage/Storage.cpp - Issue 2375873003: Make DOMWindowProperty::m_frame private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/storage/Storage.cpp

Issue 2375873003: Make DOMWindowProperty::m_frame private (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/storage/Storage.cpp

diff --git a/third_party/WebKit/Source/modules/storage/Storage.cpp b/third_party/WebKit/Source/modules/storage/Storage.cpp

index 372f916d90bf88df0838c07375930a8f054d85f5..e73646a4e64c60eb7107bf340da1874c8274ac24 100644

--- a/third_party/WebKit/Source/modules/storage/Storage.cpp

+++ b/third_party/WebKit/Source/modules/storage/Storage.cpp

@@ -40,8 +40,8 @@ Storage::Storage(LocalFrame* frame, StorageArea* storageArea)

: DOMWindowProperty(frame)

, m_storageArea(storageArea)

{

- ASSERT(m_frame);

- ASSERT(m_storageArea);

+ DCHECK(frame);

+ DCHECK(m_storageArea);

}

String Storage::anonymousNamedGetter(const AtomicString& name, ExceptionState& exceptionState)