third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp - Issue 2375873003: Make DOMWindowProperty::m_frame private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

Issue 2375873003: Make DOMWindowProperty::m_frame private (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceTiming.cpp ('k') | third_party/WebKit/Source/modules/plugins/DOMMimeTypeArray.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

diff --git a/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp b/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

index 6a8d01d2a8b087d52722215592512ddf292f38ff..09a2f9424241aa34cb37c5e1e36ad1c1f1cf0694 100644

--- a/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

+++ b/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp

@@ -71,7 +71,7 @@ ScriptPromise NavigatorInstalledApp::getInstalledRelatedApps(ScriptState* script

ScriptPromise promise = resolver->promise();

// Don't crash when called and unattached to document.

- Document* document = m_frame ? m_frame->document() : 0;

+ Document* document = frame() ? frame()->document() : 0;

if (!document || !controller()) {

DOMException* exception = DOMException::create(InvalidStateError, "The object is no longer associated to a document.");