Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp

Issue 2375873003: Make DOMWindowProperty::m_frame private (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp
diff --git a/third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp b/third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp
index 32d1c9683c85f25157b6b53ebee80719f089dae9..f03df985b513a29f4492840ff744ac62d3ff4aa6 100644
--- a/third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp
+++ b/third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp
@@ -53,7 +53,7 @@ DOMPlugin* DOMPluginArray::item(unsigned index)
const Vector<PluginInfo>& plugins = data->plugins();
if (index >= plugins.size())
return nullptr;
- return DOMPlugin::create(data, m_frame, index);
+ return DOMPlugin::create(data, frame(), index);
}
DOMPlugin* DOMPluginArray::namedItem(const AtomicString& propertyName)
@@ -64,25 +64,25 @@ DOMPlugin* DOMPluginArray::namedItem(const AtomicString& propertyName)
const Vector<PluginInfo>& plugins = data->plugins();
for (unsigned i = 0; i < plugins.size(); ++i) {
if (plugins[i].name == propertyName)
- return DOMPlugin::create(data, m_frame, i);
+ return DOMPlugin::create(data, frame(), i);
}
return nullptr;
}
void DOMPluginArray::refresh(bool reload)
{
- if (!m_frame)
+ if (!frame())
return;
Page::refreshPlugins();
if (reload)
- m_frame->reload(FrameLoadTypeReload, ClientRedirectPolicy::ClientRedirect);
+ frame()->reload(FrameLoadTypeReload, ClientRedirectPolicy::ClientRedirect);
}
PluginData* DOMPluginArray::pluginData() const
{
- if (!m_frame)
+ if (!frame())
return nullptr;
- return m_frame->pluginData();
+ return frame()->pluginData();
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698